ImageCustomizer: Refresh partitions after veritysetup so that hash partition's UUID is accurate #11247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liulanze
approved these changes
Nov 27, 2024
romoh
requested changes
Dec 2, 2024
There was a problem hiding this comment.
Please move PR to new repo https://github.com/microsoft/azure-linux-image-tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change corrects the value set for the
systemd.verity_root_hash=kernel cmdline parameter whenhashDeviceMountIdTypein the configuration is set touuid.In particular, the veritysetup command earlier in the function generates the UUID for the verity hash partition. But since the diskPartitions array is queried before that call, the partition would be marked as having an empty filesystem UUID.
An alternative would be to edit only the specific partition's UUID in the diskPartitions array, either by passing a manually generated UUID to veritysetup (via the
--uuid=UUIDflag) or by querying the chosen UUID after veritysetup had run.Does this affect the toolchain?
NO
Test Methodology